Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48528 )
Change subject: soc/amd/cezanne: Add PSP integration for cezanne ......................................................................
Patch Set 7:
(3 comments)
only did a very brief review and didn't look into the details yet
https://review.coreboot.org/c/coreboot/+/48528/7/src/soc/amd/cezanne/Kconfig File src/soc/amd/cezanne/Kconfig:
https://review.coreboot.org/c/coreboot/+/48528/7/src/soc/amd/cezanne/Kconfig... PS7, Line 104: config AMDFW_OUTSIDE_CBFS : bool : default n : help : The AMDFW (PSP) is typically locatable in cbfs. Select this : option to manually attach the generated amdfw.rom outside of : cbfs. The location is selected by the FWM position. this can be removed, since it's unused and was implemented in a very unsafe way when i removed it from picasso
https://review.coreboot.org/c/coreboot/+/48528/7/src/soc/amd/cezanne/Makefil... File src/soc/amd/cezanne/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48528/7/src/soc/amd/cezanne/Makefil... PS7, Line 64: #PSP_SOFTFUSE_BITS += 29 this probably shouldn't be commented out
https://review.coreboot.org/c/coreboot/+/48528/7/src/soc/amd/cezanne/fw.cfg File src/soc/amd/cezanne/fw.cfg:
https://review.coreboot.org/c/coreboot/+/48528/7/src/soc/amd/cezanne/fw.cfg@... PS7, Line 11: #4? : #PSPNVRAM_FILE PspNvramCZN_2.bin please remove instead of commenting out