HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43054 )
Change subject: acpi: Bump SRAT revision to 3 ......................................................................
Patch Set 5:
(8 comments)
https://review.coreboot.org/c/coreboot/+/43054/5/src/include/acpi/acpi.h File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/43054/5/src/include/acpi/acpi.h@261 PS5, Line 261: u16 resv; u16 resv; /* Reserved, must be zero *
https://review.coreboot.org/c/coreboot/+/43054/5/src/include/acpi/acpi.h@266 PS5, Line 266: acpi_srat_gen_init_struct maybe "acpi_srat_generic_initiator" ?
https://review.coreboot.org/c/coreboot/+/43054/5/src/include/acpi/acpi.h@269 PS5, Line 269: Reserved Reserved and must be zero
https://review.coreboot.org/c/coreboot/+/43054/5/src/include/acpi/acpi.h@269 PS5, Line 269: u16 u8 ?
https://review.coreboot.org/c/coreboot/+/43054/5/src/include/acpi/acpi.h@269 PS5, Line 269: resv1 maybe "resv"
https://review.coreboot.org/c/coreboot/+/43054/5/src/include/acpi/acpi.h@273 PS5, Line 273: /* */ /* bit 0: if clear, the OSPM ignores the contents of acpi_srat_gicc. * bit[31:1] must be 0 */
https://review.coreboot.org/c/coreboot/+/43054/5/src/include/acpi/acpi.h@274 PS5, Line 274: resv2 maybe "resv1"?
https://review.coreboot.org/c/coreboot/+/43054/5/src/include/acpi/acpi.h@963 PS5, Line 963: int acpi_create_srat_gen_init_struct_(acpi_srat_gen_init_struct_t acpi_create_srat_generic_initiator(acpi_srat_generic_initiator... ?