[coreboot-gerrit] [M] Change in coreboot[main]: Add MTCL function to ACPI SSDT tables

[Subrata Banik (Code Review)]

Attention is currently required from: Cliff Huang, David Ruth, Lance Zhao, Nico Huber, Paul Menzel, Subrata Banik, Tim Wawrzynczak.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80170?usp=email )

The change is no longer submittable: All-Comments-Resolved is unsatisfied now.

Change subject: Add MTCL function to ACPI SSDT tables
......................................................................

Patch Set 14:

(2 comments)

File src/drivers/wifi/generic/mtcl.c:

https://review.coreboot.org/c/coreboot/+/80170/comment/e06bb933_efe9128d :
PS14, Line 9:  WIFI_MTCL_CBFS_DEFAULT_FILENAME "wifi_mtcl.hex"
nit: can we use `WIFI_MTCL_CBFS_FILEPATH` config directly here ? (instead of defining a new macro)?

just update the default value directly to the WIFI_MTCL_CBFS_FILEPATH config

https://review.coreboot.org/c/coreboot/+/80170/comment/0a8e4ff1_7215ac42 :
PS14, Line 10: #define MAX_VERSION 2
             : #define MAX_SUPPORT_STATE 2
             : #define COUNTRY_LIST_SIZE 6
             : #define NAME_SIZE 4
             : #define MTCL_NAME "MTCL"
nit: wondering if moving these macros into mtcl.h makes sense.?