Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47350 )
Change subject: lp4x: Add new memory parts and generate SPDs ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47350/1/util/spd_tools/lp4x/global_... File util/spd_tools/lp4x/global_lp4x_mem_parts.json.txt:
https://review.coreboot.org/c/coreboot/+/47350/1/util/spd_tools/lp4x/global_... PS1, Line 191: 2 Is this correct? Page 3 of the spec attached to the bug shows the part as being a QDP.
https://review.coreboot.org/c/coreboot/+/47350/1/util/spd_tools/lp4x/global_... PS1, Line 203: 4 Is this correct? Page 3 of part spec attached to bug shows this part to be an ODP.
https://review.coreboot.org/c/coreboot/+/47350/1/util/spd_tools/lp4x/global_... PS1, Line 215: 2 Is this correct? Page 2 of part spec attached to bug shows this part to be a QDP.