Nick Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44632 )
Change subject: mb/google/volteer/variants/eldrid: add memory.c for ddr4 support ......................................................................
Patch Set 13:
(6 comments)
https://review.coreboot.org/c/coreboot/+/44632/11/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/eldrid/gpio.c:
https://review.coreboot.org/c/coreboot/+/44632/11/src/mainboard/google/volte... PS11, Line 79: EN_PP3300_SD
i think you'll want this in early_gpio as well.
Done
https://review.coreboot.org/c/coreboot/+/44632/9/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/eldrid/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44632/9/src/mainboard/google/voltee... PS9, Line 6: register "SaGv" = "SaGv_Disabled"
Done
When SaGv removed from this line, coreboot hang at memory init. I add back from default.
https://review.coreboot.org/c/coreboot/+/44632/11/src/mainboard/google/volte... File src/mainboard/google/volteer/variants/eldrid/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/44632/11/src/mainboard/google/volte... PS11, Line 64: probe AUDIO MAX98357_ALC5682I_I2S : probe AUDIO MAX98373_ALC5682I_I2S
your audio config is on the MLB and can't change, right? […]
Done
https://review.coreboot.org/c/coreboot/+/44632/11/src/mainboard/google/volte... PS11, Line 116: probe
no need to probe if always on MLB.
Done
https://review.coreboot.org/c/coreboot/+/44632/11/src/mainboard/google/volte... PS11, Line 119: chip drivers/intel/soundwire : device generic 0 on : probe AUDIO MAX98373_ALC5682_SNDW : chip drivers/soundwire/alc5682 : # SoundWire Link 0 ID 1 : register "desc" = ""Headset Codec"" : device generic 0.1 on end : end : chip drivers/soundwire/max98373 : # SoundWire Link 1 ID 3 : register "desc" = ""Left Speaker Amp"" : device generic 1.3 on end : end : chip drivers/soundwire/max98373 : # SoundWire Link 1 ID 7 : register "desc" = ""Right Speaker Amp"" : device generic 1.7 on end : end : end : end
no soundwire on this board, right?
Done
https://review.coreboot.org/c/coreboot/+/44632/11/src/mainboard/google/volte... PS11, Line 157: probe DB_USB USB4_GEN2 : probe DB_USB USB3_ACTIVE : probe DB_USB USB4_GEN3 : probe DB_USB USB3_NO_A
do you plan to support multiple USB DB types?
Done