[coreboot-gerrit] Change in coreboot[master]: cpu/x86: Fix MSR_PLATFORM_INFO definition

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34090 )

Change subject: cpu/x86: Fix MSR_PLATFORM_INFO definition
......................................................................

Patch Set 4:
> Patch Set 4:
>
> I wouldn't mind common, non-architectural MSR definitions in
> a common place. As long as it's clear from the prefix, MSR_
> instead of IA32_, that wouldn't seem bad, would it?

It gets interesting fast if Intel is not consistent and reuses the names in documentation but at different register address.

I came across this:
  eg. haswell.h:
  #define MSR_PLATFORM_INFO 0xce
  #define  PLATFORM_INFO_SET_TDP (1 << 29)

cpu/x86/msr.h:
  #define IA32_FEATURE_CONTROL 0x3a
  #define  PLATFORM_INFO_SET_TDP (1 << 29)

But now that I looked deeper, seems like a mistake made in CB:28752 for the latter define.

See CB:33504