Attention is currently required from: Arthur Heymans, Lean Sheng Tan, Patrick Rudolph, Shuo Liu.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81209?usp=email )
Change subject: symbols: Add __maybe_unused flag to region variable symbols
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Since this is a workaround, we didn't intend to spread the changes to a global context. […]
I mean, I still don't see why you can't just declare it at global scope in the `memory_init.c` file.
I guess I don't really mind adding the `__maybe_unused` either... but if you want to do that please add it t everything (`_name`, `_ename` and `_name_size` for both `DECLARE_REGION` and `DECLARE_OPTIONAL_REGION`), to keep things consistent.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81209?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia5ed183b2dd7a474ce51de47dbc1f9e3f61e5a41
Gerrit-Change-Number: 81209
Gerrit-PatchSet: 2
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Thu, 14 Mar 2024 15:06:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shuo Liu
shuo.liu@intel.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment