Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38846 )
Change subject: soc/intel/cannonlake: Plumb TetonGlacierMode into dt
......................................................................
Patch Set 3:
(2 comments)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/38846/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38846/2//COMMIT_MSG@6
PS2, Line 6:
: mainboard/hatch
mb/google/hatch
Ack
https://review.coreboot.org/c/coreboot/+/38846/2/src/soc/intel/cannonlake/ch...
File src/soc/intel/cannonlake/chip.h:
https://review.coreboot.org/c/coreboot/+/38846/2/src/soc/intel/cannonlake/ch...
PS2, Line 245: //
why bother
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38846
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id9a72161494db6a4da4abd3302b06df7c70634ab
Gerrit-Change-Number: 38846
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@chromium.org
Gerrit-Reviewer: David Jimenez
dvjimenez@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 21 Feb 2020 05:18:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment