Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38350 )
Change subject: soc/intel/broadwell: Don't use _ADR and _HID ......................................................................
Patch Set 8: Code-Review+1
Patch Set 8:
If anyone disagrees with these patches,
I do. It leaves the tree in an inconsistent state. Nothing changed since this was reverted. We have discussed this in depth about three times already. Many alternatives were proposed. IIRC, we even agreed that the lynxpoint/broadwell code around _ADR (sio_acpi_mod = 0) can be removed altogether.
I've also proposed to disable the warning (imho, it doesn't provide any value, just a huge waste of time). Nobody liked that, though.
Ok, So you're saying you agree with my suggested patch then? Or do you care to write something different?
I don't care anymore (as long as it's not leaving dead code). Spent too much time on this already, and there is nothing to gain.
I have a WIP port using sio_acpi_mode = 0, but now that it boots I don't really depend on the UART (part of Serial IO, I had it working in PCI mode for coreboot logs) as much.
Patch Set 8:
Patch: https://review.coreboot.org/c/coreboot/+/38810
It allows us to update IASL: https://qa.coreboot.org/job/coreboot_updated_iasl/647/
Sounds good, let's get it done!