Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46651 )
Change subject: sc7180: enable RECOVERY_MRC_CACHE ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46651/1/src/mainboard/google/trogdo... File src/mainboard/google/trogdor/chromeos.fmd:
https://review.coreboot.org/c/coreboot/+/46651/1/src/mainboard/google/trogdo... PS1, Line 17:
I think you should be able to set PRESERVE here for UNIFIED_MRC_CACHE and not worry about setting th […]
Done
https://review.coreboot.org/c/coreboot/+/46651/1/src/soc/qualcomm/sc7180/Kco... File src/soc/qualcomm/sc7180/Kconfig:
https://review.coreboot.org/c/coreboot/+/46651/1/src/soc/qualcomm/sc7180/Kco... PS1, Line 21: HAS_RECOVERY_MRC_CACHE
Yes, this is already below on line 35. […]
Ok, I updated the fmap. Let me figure out what to do with the HAS_RECOVERY_MRC_CACHE with Julius.