Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47835 )
Change subject: mb/clevo/cml-u: Get rid of cnl_configure_pads() ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47835/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47835/3//COMMIT_MSG@9 PS3, Line 9: since is a hack for the FSP
The only "special case" is the FSP here. It configures GPIOs that it shouldn't.
Well, but we use FSP and thus it's confusing ;) People will ask "why don't we need the hack when we use fsp?".
What I meant was that it seems only to be required under special circumstances, which we don't know.