Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35208 )
Change subject: soc/intel/skylake: Add option to toggle Hyper-Threading
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/35208/1/src/soc/intel/skylake/Kconf...
File src/soc/intel/skylake/Kconfig:
https://review.coreboot.org/c/coreboot/+/35208/1/src/soc/intel/skylake/Kconf...
PS1, Line 83: SOC_INTEL_KABYLAKE
SKL don't have this option.
Why not? FSP 2.0 runs on both Skylake and Kabylake, if it provides that option it should work for both...
If you mean the Skylake-only FSP 1.1 doesn't have that option, then this should depend on FSP 2.0 instead.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35208
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ebab68ff868c78105bb4b35abffb92f3ccf1705
Gerrit-Change-Number: 35208
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 04 Sep 2019 15:29:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment