Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31047 )
Change subject: src/mb/sifive/hifive-unleashed: replace fdt in maskrom
......................................................................
Patch Set 14: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/31047/14/src/mainboard/sifive/hifive-unleash...
File src/mainboard/sifive/hifive-unleashed/Makefile.inc:
https://review.coreboot.org/#/c/31047/14/src/mainboard/sifive/hifive-unleash...
PS14, Line 15: bootblock-y += fixup_fdt.c
why ?
https://review.coreboot.org/#/c/31047/14/src/mainboard/sifive/hifive-unleash...
File src/mainboard/sifive/hifive-unleashed/fixup_fdt.c:
https://review.coreboot.org/#/c/31047/14/src/mainboard/sifive/hifive-unleash...
PS14, Line 5: *
Add your copyright here ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31047
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic29f0e590311360b85fafd12ebc36cd189fbbc38
Gerrit-Change-Number: 31047
Gerrit-PatchSet: 14
Gerrit-Owner: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: Jonathan Neuschäfer
j.neuschaefer@gmx.net
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: Shawn C
citypw@gmail.com
Gerrit-Reviewer: Xiang Wang
wxjstz@126.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 27 Feb 2019 08:31:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment