[coreboot-gerrit] Change in coreboot[master]: drivers/intel/usb4: Add driver for USB4 retimer device

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44918 )

Change subject: drivers/intel/usb4: Add driver for USB4 retimer device
......................................................................

Patch Set 12:

(2 comments)

https://review.coreboot.org/c/coreboot/+/44918/12/src/drivers/intel/usb4/ret... 
File src/drivers/intel/usb4/retimer/retimer.c:

https://review.coreboot.org/c/coreboot/+/44918/12/src/drivers/intel/usb4/ret... 
PS12, Line 39: 0x0F
> This doesn't match the comment above. […]

When bit 0 is set, it means that "more bits follow":

```
Bit 0 indicates whether there is support for any functions other than function 0 for the specified
UUID and Revision ID. If set to zero, no functions are supported (other than function zero) for the
specified UUID and Revision ID. If set to one, at least one additional function is supported
```

We should make a macro for this b/c I've seen this come up in reviews before.

https://review.coreboot.org/c/coreboot/+/44918/12/src/drivers/intel/usb4/ret... 
PS12, Line 43: 0x03
> Doesn't match the comment. […]

same.