Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31377 )
Change subject: util/ifdtools: Make EC region readable to BIOS/CPU
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31377/1/util/ifdtool/ifdtool.c
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/#/c/31377/1/util/ifdtool/ifdtool.c@973
PS1, Line 973: 10
Wondering if this should be behind a Kconfig option. I remember Duncan had mentioned this doesn't matter if there is no EC region -- so probably might be okay to just do it.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31377
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I306c74a0893355e57632a22a712b1f4fdaa19306
Gerrit-Change-Number: 31377
Gerrit-PatchSet: 1
Gerrit-Owner: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Tue, 12 Feb 2019 21:37:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment