Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44167 )
Change subject: mb/acer/m3800: add Acer Aspire M3800 desktop ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/44167/1/src/mainboard/acer/m3800/Kc... File src/mainboard/acer/m3800/Kconfig:
https://review.coreboot.org/c/coreboot/+/44167/1/src/mainboard/acer/m3800/Kc... PS1, Line 12: BOARD_ROMSIZE_KB_2048 Just wondering, does it have an ME region?
https://review.coreboot.org/c/coreboot/+/44167/1/src/mainboard/acer/m3800/cm... File src/mainboard/acer/m3800/cmos.layout:
https://review.coreboot.org/c/coreboot/+/44167/1/src/mainboard/acer/m3800/cm... PS1, Line 55: 1024 144 r 0 recv_enable_results Drop this. It's unused now.
https://review.coreboot.org/c/coreboot/+/44167/1/src/mainboard/acer/m3800/ea... File src/mainboard/acer/m3800/early_init.c:
https://review.coreboot.org/c/coreboot/+/44167/1/src/mainboard/acer/m3800/ea... PS1, Line 9: RCBA32(0x3414) &= ~BUC_LAND; // BUC := Backed Up Control -> LAN is enabled Is this really needed?