Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37267 )
Change subject: soc/intel/tigerlake: Select correct fsp_param as per SoC Kconfig ......................................................................
Patch Set 12:
(4 comments)
https://review.coreboot.org/c/coreboot/+/37267/1/src/soc/intel/tigerlake/Mak... File src/soc/intel/tigerlake/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37267/1/src/soc/intel/tigerlake/Mak... PS1, Line 1: CONFIG_SOC_INTEL_TIGERLAKE_BASE
yes, will push separate patch for it
Done
https://review.coreboot.org/c/coreboot/+/37267/1/src/soc/intel/tigerlake/Mak... PS1, Line 36: fsp_params_tgl.c
No fsp_params for jasperlake?
Done
https://review.coreboot.org/c/coreboot/+/37267/9/src/soc/intel/tigerlake/Mak... File src/soc/intel/tigerlake/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37267/9/src/soc/intel/tigerlake/Mak... PS9, Line 36: ramstage-$(CONFIG_SOC_INTEL_TIGERLAKE) += fsp_params_tgl.c
Done
Done
https://review.coreboot.org/c/coreboot/+/37267/3/src/soc/intel/tigerlake/fsp... File src/soc/intel/tigerlake/fsp_params_tgl.c:
https://review.coreboot.org/c/coreboot/+/37267/3/src/soc/intel/tigerlake/fsp... PS3, Line 17: #include <fsp/api.h>
also needs #include <intelblocks/lpss. […]
Done