Attention is currently required from: Liju-Clr Chen, Rex-BC Chen, Yu-Ping Wu, Yidi Lin.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69088 )
Change subject: soc/mediatek/mt8188: Allow MCUPM to access the secure registers
......................................................................
Patch Set 1:
(1 comment)
File src/soc/mediatek/mt8188/devapc.c:
https://review.coreboot.org/c/coreboot/+/69088/comment/d087da94_c4db925a
PS1, Line 1557: SCP_SSPM_DOM, DOMAIN_2
For MT8188, DEVAPC configures the hardwares(AP/others) as domain 0 by default and enables no_protect […]
can you add what you commented to the commit description?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69088
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67b08c38a31a7eae1bc59543a5148a78b61456d6
Gerrit-Change-Number: 69088
Gerrit-PatchSet: 1
Gerrit-Owner: Liju-Clr Chen
liju-clr.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Liju-Clr Chen
liju-clr.chen@mediatek.corp-partner.google.com
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Tue, 01 Nov 2022 07:47:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Liju-Clr Chen
liju-clr.chen@mediatek.corp-partner.google.com
Gerrit-MessageType: comment