Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39581 )
Change subject: src/soc/intel/jasperlake: Update SD card ACPI device ......................................................................
Patch Set 4:
(9 comments)
https://review.coreboot.org/c/coreboot/+/39581/4/src/soc/intel/jasperlake/ac... File src/soc/intel/jasperlake/acpi/scs.asl:
https://review.coreboot.org/c/coreboot/+/39581/4/src/soc/intel/jasperlake/ac... PS4, Line 95: If (LEqual (Arg0, DSUU)) {
Just to confirm, that would be If (Arg0 == DSUU) {?
Yes.
https://review.coreboot.org/c/coreboot/+/39581/4/src/soc/intel/jasperlake/ac... PS4, Line 97: LGreaterEqual (Arg1, Zero) Arg1 >= 0
https://review.coreboot.org/c/coreboot/+/39581/4/src/soc/intel/jasperlake/ac... PS4, Line 115: LEqual (Arg2, Zero) Arg2 == 0
https://review.coreboot.org/c/coreboot/+/39581/4/src/soc/intel/jasperlake/ac... PS4, Line 125: LEqual (Arg2, 3) Arg2 == 3
https://review.coreboot.org/c/coreboot/+/39581/4/src/soc/intel/jasperlake/ac... PS4, Line 136: LEqual (Arg2, 4) Arg2 == 4
https://review.coreboot.org/c/coreboot/+/39581/4/src/soc/intel/jasperlake/ac... PS4, Line 159: And (PMCR, 0xFFFC, PMCR) PMCR = PMCR & 0xFFFC
https://review.coreboot.org/c/coreboot/+/39581/4/src/soc/intel/jasperlake/ac... PS4, Line 160: Store (PMCR, TEMP) TEMP = PMCR
https://review.coreboot.org/c/coreboot/+/39581/4/src/soc/intel/jasperlake/ac... PS4, Line 171: Or (PMCR, 0x0003, PMCR) PMCR = PMCR | 0x0003
https://review.coreboot.org/c/coreboot/+/39581/4/src/soc/intel/jasperlake/ac... PS4, Line 172: Store (PMCR, TEMP) TEMP = PMCR