Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37638 )
Change subject: superio/*: Don't use conf_mode directly
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37638/2/src/superio/smsc/lpc47n227/...
File src/superio/smsc/lpc47n227/superio.c:
https://review.coreboot.org/c/coreboot/+/37638/2/src/superio/smsc/lpc47n227/...
PS2, Line 45: static struct device_operations ops = {
the ops struct lacks the .ops_pnp_mode assignment, so i'd guess that this will break this sio driver
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37638
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibb94d86b3ee861f44cded469ff58b545dd7311fd
Gerrit-Change-Number: 37638
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 11 Dec 2019 20:09:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment