Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33151 )
Change subject: mb/apple: Add MacBook Pro 8,1 support ......................................................................
Patch Set 13:
(3 comments)
https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/Kconfig:
https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 1: BOARD_APPLE_MACBOOKPRO8_1
Then we need to change macbookair4_2 and other ports as well. […]
Ack
https://review.coreboot.org/c/coreboot/+/33151/11/src/mainboard/apple/macboo... PS11, Line 22: macbookpro8_1
Same here
Ack
https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro8_1/gpio.c:
https://review.coreboot.org/c/coreboot/+/33151/13/src/mainboard/apple/macboo... PS13, Line 30: gpio9
are you suggesting to change all this, or what?
No, I was keeping track of what the OC# pins were.