Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41429 )
Change subject: soc/intel/jasperlake: Add ISST override support ......................................................................
Patch Set 1:
Patch Set 1:
Couple of reasons I added this callback:
- It happens as part of CPU initialization. It definitely happens before mainboard Silicon initialization(as pointed out by Tim). I have to check if mainboard Chip initialization. If this happens before CPU initialization, then we can update the configuration there.
This is the sequence in which different bootstates are executed: https://review.coreboot.org/cgit/coreboot.git/tree/src/include/bootstate.h?i.... IIUC, CPU initialization is being done as part of BS_DEV_INIT, whereas mainboard chip initialization happens in BS_DEV_INIT_CHIPS.
I see that CPUs are getting initialized also at BS_DEV_INIT_CHIPS boot state - https://review.coreboot.org/cgit/coreboot.git/tree/src/soc/intel/common/bloc...
The test also indicates the ISST is getting enabled if moved to mainboard chip init.