Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46389 )
Change subject: mediatek/mt8192: add spmfw loader
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46389/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46389/4//COMMIT_MSG@12
PS4, Line 12: SPM is able to turn off more power saving for
: the SoC such as DRAM self-refresh
“turn off more power saving” sounds strange.
https://review.coreboot.org/c/coreboot/+/46389/4//COMMIT_MSG@16
PS4, Line 16: TEST=Asurada boots up to shell
It didn’t before? I thought it’s about suspend and resume?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46389
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6478b98f426d2f3e0ee919d37d21d909ae8a6371
Gerrit-Change-Number: 46389
Gerrit-PatchSet: 4
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Roger Lu
roger.lu@mediatek.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 16 Oct 2020 13:29:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment