Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35762 )
Change subject: sb/intel/ibexpeak: Implement USB current settings
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35762/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35762/3//COMMIT_MSG@14
PS3, Line 14: register replay.
Do you know what is different? Shouldn’t we trust the board manufacturer?
Who to trust the vendor firmware developer which may be using newer or older information or a leaked Intel EDS? I can add a comment in the code, that EDS is chosen.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35762
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icea9673623a62e7039d5700100a2ee238478abd1
Gerrit-Change-Number: 35762
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 03 Oct 2019 05:11:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment