Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37792 )
Change subject: {drivers,soc}/intel/fsp2_0: Move chipset specific logo handling to SoC ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37792/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37792/4//COMMIT_MSG@13 PS4, Line 13: load the logo pass logo parameters to FSP?
https://review.coreboot.org/c/coreboot/+/37792/4/src/drivers/intel/fsp2_0/Kc... File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/37792/4/src/drivers/intel/fsp2_0/Kc... PS4, Line 159: space
https://review.coreboot.org/c/coreboot/+/37792/4/src/drivers/intel/fsp2_0/lo... File src/drivers/intel/fsp2_0/logo.c:
https://review.coreboot.org/c/coreboot/+/37792/4/src/drivers/intel/fsp2_0/lo... PS4, Line 29: if (logo_size) : *logo_ptr = (UINT32)logo_buffer; else remove cbmem entry and set logo_entry=NULL?