19 Sep
2019
19 Sep
'19
6:16 a.m.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35463 )
Change subject: device/mmio.h: Add bit field helpers ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35463/2/src/include/device/mmio.h File src/include/device/mmio.h:
https://review.coreboot.org/c/coreboot/+/35463/2/src/include/device/mmio.h@9... PS2, Line 92: #define DEFINE_BITFIELD(name, start, end) \ Macros with multiple statements should be enclosed in a do - while loop
https://review.coreboot.org/c/coreboot/+/35463/2/src/include/device/mmio.h@1... PS2, Line 119: #define _BF_APPLYINVALID(...) \ macros should not use a trailing semicolon
--
To view, visit https://review.coreboot.org/c/coreboot/+/35463
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8a1b17142f7a7dc6c441b0b1ee67d60d73ec8cc8
Gerrit-Change-Number: 35463
Gerrit-PatchSet: 2
Gerrit-Owner: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 19 Sep 2019 04:16:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment