Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37354 )
Change subject: mb/intel/icelake_rvp: Remove unused mainboard ACPI write table ......................................................................
mb/intel/icelake_rvp: Remove unused mainboard ACPI write table
Change-Id: I19040cca064c2ce063aab77391e0577271c6e9dc Signed-off-by: Aamir Bohra aamir.bohra@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37354 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Rizwan Qureshi rizwan.qureshi@intel.com Reviewed-by: Lean Sheng Tan lean.sheng.tan@intel.com Reviewed-by: Ronak Kanabar ronak.kanabar@intel.com --- M src/mainboard/intel/icelake_rvp/mainboard.c 1 file changed, 0 insertions(+), 12 deletions(-)
Approvals: build bot (Jenkins): Verified Rizwan Qureshi: Looks good to me, approved Lean Sheng Tan: Looks good to me, but someone else must approve Ronak Kanabar: Looks good to me, approved
diff --git a/src/mainboard/intel/icelake_rvp/mainboard.c b/src/mainboard/intel/icelake_rvp/mainboard.c index 36d6a3e..8e51e45 100644 --- a/src/mainboard/intel/icelake_rvp/mainboard.c +++ b/src/mainboard/intel/icelake_rvp/mainboard.c @@ -29,20 +29,8 @@ gpio_configure_pads(pads, num); }
-static unsigned long mainboard_write_acpi_tables(struct device *device, - unsigned long current, - acpi_rsdp_t *rsdp) -{ - uintptr_t start_addr; - - start_addr = current; - - return start_addr; -} - static void mainboard_enable(struct device *dev) { - dev->ops->write_acpi_tables = mainboard_write_acpi_tables; dev->ops->acpi_inject_dsdt_generator = chromeos_dsdt_generator; }