Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48861 )
Change subject: payloads/tianocore: Add Kconfig to set boot timeout ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48861/1/payloads/external/tianocore... File payloads/external/tianocore/Kconfig:
https://review.coreboot.org/c/coreboot/+/48861/1/payloads/external/tianocore... PS1, Line 109: For boards without an internal display, a value of 5s is generally sufficient.
The default is supposed to be set per board, I assume?
just for boards (with an external display) that need a longer timeout; the current default of 2s has never been problematic IME for boards with an internal display
https://review.coreboot.org/c/coreboot/+/48861/1/payloads/external/tianocore... File payloads/external/tianocore/Makefile:
https://review.coreboot.org/c/coreboot/+/48861/1/payloads/external/tianocore... PS1, Line 45: BUILD_STR=-q -a IA32 -a X64 -t COREBOOT -p $(bootloader)/$(bootloader)Ia32X64.dsc -b $(BUILD_TYPE) $(TIMER) $(TIMEOUT) $(build_flavor)
Would it make sense to extract `-a` and `-p` arguments into another variable? […]
it absolutely would, I'll do that in a follow-up