11 Feb
2020
11 Feb
'20
8:29 a.m.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38828 )
Change subject: util/ifdtool: add --output flag ......................................................................
Patch Set 2:
(1 comment)
The new flag will only work for mode_newlayout as the other commands used to operate in place. You have to either copy the file contents first or limit -O to newlayout generation.
https://review.coreboot.org/c/coreboot/+/38828/2/util/ifdtool/ifdtool.c File util/ifdtool/ifdtool.c:
https://review.coreboot.org/c/coreboot/+/38828/2/util/ifdtool/ifdtool.c@1741 PS2, Line 1741: malloc((strlen(filename)) Strlen(Filename) +5
--
To view, visit https://review.coreboot.org/c/coreboot/+/38828
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I824e94e93749f55c3576e4ee2f7804d855fefed2
Gerrit-Change-Number: 38828
Gerrit-PatchSet: 2
Gerrit-Owner: Marcello Sylvester Bauer sylv@sylv.io
Gerrit-Reviewer: Marcello Sylvester Bauer sylv@sylv.io
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 11 Feb 2020 16:29:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment