Jenny Tc has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31635 )
Change subject: soc/intel/skylake: nhlt: Add 24-bit blobs for Max98373
......................................................................
Patch Set 5:
Patch Set 5:
I tried this on a nocturne and didn't get any sound, but I suspect it to be the nocturne. I will try to get back to verifying this on a different nocturne today, just been a bit busy lately.
This patch depends on series of kernel, overlay and private overlay patches
Kernel: 9 patches: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1...
Overlay 1 patch: https://chromium-review.googlesource.com/c/chromiumos/overlays/board-overlay...
Private overlays 3 patches: https://chrome-internal-review.googlesource.com/q/topic:24bit-audio
Could you please try with all the changes?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31635
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62cc109fb0aca9269736779a6ce80980b0571b78
Gerrit-Change-Number: 31635
Gerrit-PatchSet: 5
Gerrit-Owner: Jenny Tc
jenny.tc@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jenny Tc
jenny.tc@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: caveh jalali
caveh@chromium.org
Gerrit-CC: Jenny Tc
jenny.tc@intel.corp-partner.google.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Tue, 09 Apr 2019 04:02:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment