Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37490 )
Change subject: soc/amd/picasso: Add bootblock support
......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37490/13/src/soc/amd/picasso/Kconfi...
File src/soc/amd/picasso/Kconfig:
https://review.coreboot.org/c/coreboot/+/37490/13/src/soc/amd/picasso/Kconfi...
PS13, Line 48: config HAVE_BOOTBLOCK
IIRC this feature simply writes FFs into a smaller bootblock image which is still included. […]
Removing this just means we no longer create an empty bootblock.bin: https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/th...
We can save all the moving and refactoring for later. For now I just want to get enough of this merged so anyone can start building and testing without having to juggle a huge patch train.
https://review.coreboot.org/c/coreboot/+/37490/13/src/soc/amd/picasso/Kconfi...
PS13, Line 224: 0x10000
This is the same as the default value in src/arch/x86/Kconfig. […]
Nope. Removed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37490
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d0784025f2b39f140b16f37726d4a7f36df6c6c
Gerrit-Change-Number: 37490
Gerrit-PatchSet: 14
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 28 Apr 2020 17:55:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment