Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42470 )
Change subject: drivers/intel/mipi_camera: Add support to handle CIO2 device ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42470/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42470/2//COMMIT_MSG@7 PS2, Line 7: drivers/intel/mipi_camera: SSDT changes to handle CIO2 device
Please make it a statement by adding a verb (in imperative mood).
Done
https://review.coreboot.org/c/coreboot/+/42470/2/src/drivers/intel/mipi_came... File src/drivers/intel/mipi_camera/camera.c:
https://review.coreboot.org/c/coreboot/+/42470/2/src/drivers/intel/mipi_came... PS2, Line 13: #define CIO2_PCI_DEV 0x14 : #define CIO2_PCI_FN 0x3
nit: tab after CIO2_PCI_...
Done
https://review.coreboot.org/c/coreboot/+/42470/2/src/drivers/intel/mipi_came... PS2, Line 57: ;
&& j <= MAX_PORT_ENTRIES
Done
https://review.coreboot.org/c/coreboot/+/42470/2/src/drivers/intel/mipi_came... PS2, Line 261: "\_SB.PCI0.CIO2"
nit: maybe #define DEFAULT_REMOTE_NAME "\_SB.PCI0. […]
Done