build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47586 )
Change subject: mb/google/kukui: Fix no firmware beep issue ......................................................................
Patch Set 1:
(20 comments)
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/Kconfig:
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 20: config RT1015_I2C_MODE DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 21: bool DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 22: default n DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 23: help DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/chromeos.c:
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 29: struct lb_gpio chromeos_gpios_1[] = { DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 30: {GPIO_WP.id, ACTIVE_LOW, DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 31: !get_write_protect_state(), "write protect"}, DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 32: {EC_IN_RW.id, ACTIVE_HIGH, -1, "EC in RW"}, DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 33: {EC_IRQ.id, ACTIVE_LOW, -1, "EC interrupt"}, DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 34: {CR50_IRQ.id, ACTIVE_HIGH, -1, "TPM interrupt"}, DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 35: }; DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 36: DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 37: if (CONFIG(RT1015_I2C_MODE)) DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 38: lb_add_gpios(gpios, chromeos_gpios_1, ARRAY_SIZE(chromeos_gpios_1)); DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 39: else DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 39: else suspect code indent for conditional statements (8, 12)
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 40: lb_add_gpios(gpios, chromeos_gpios, ARRAY_SIZE(chromeos_gpios)); DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 21: #include <soc/i2c.h> DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 59: if (CONFIG(RT1015_I2C_MODE)) DOS line endings
https://review.coreboot.org/c/coreboot/+/47586/1/src/mainboard/google/kukui/... PS1, Line 60: mtk_i2c_bus_init(6); DOS line endings