1 Sep
2021
1 Sep
'21
6:50 p.m.
Attention is currently required from: Furquan Shaikh, Derek Huang, Brandon Breitenstein, Curtis Chen. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57138 )
Change subject: src/ec/google/chromeec: Add and modify APIs for USB-C DP ALT mode ......................................................................
Patch Set 5:
(2 comments)
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/57138/comment/5df6246d_e4ff5549 PS5, Line 1567: -1 means check all port Please change this to a symbolic constant, e,g.:
`#define EC_ALL_PORTS -1`
https://review.coreboot.org/c/coreboot/+/57138/comment/33330e3d_a8a4ed56 PS5, Line 1592: >= 0 `!= EC_ALL_PORTS`
--
To view, visit https://review.coreboot.org/c/coreboot/+/57138
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id11510c1ff58579ae2cddfe5a4d69646fd84f5c3
Gerrit-Change-Number: 57138
Gerrit-PatchSet: 5
Gerrit-Owner: Derek Huang derek.huang@intel.corp-partner.google.com
Gerrit-Reviewer: Brandon Breitenstein brandon.breitenstein@intel.com
Gerrit-Reviewer: Curtis Chen curtis.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Derek Huang derek.huang@intel.corp-partner.google.com
Gerrit-Attention: Brandon Breitenstein brandon.breitenstein@intel.com
Gerrit-Attention: Curtis Chen curtis.chen@intel.corp-partner.google.com
Gerrit-Comment-Date: Wed, 01 Sep 2021 16:50:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment