Tristan Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32800 )
Change subject: mt8183: add efuse calibration in auxadc
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/32800/5/src/soc/mediatek/mt8183/auxadc.c
File src/soc/mediatek/mt8183/auxadc.c:
https://review.coreboot.org/#/c/32800/5/src/soc/mediatek/mt8183/auxadc.c@49
PS5, Line 49: cali_ge_a - 512
Hi Po,
What is the possible range of cali_ge_a?
Is it 0~1023? (since the mask is 0x3ff)
I think this might help us figure out the appropriate data type (int or uint32_t).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32800
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iccd6ea0ad810c993f9b62c0974279c960f890e52
Gerrit-Change-Number: 32800
Gerrit-PatchSet: 5
Gerrit-Owner: JG Poxu
jg_poxu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Ben Ho
Ben.Ho@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: JG Poxu
jg_poxu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 16 May 2019 01:29:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment