Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46566 )
Change subject: mb/google/zork: Correct get board version and get fw config condition ......................................................................
Patch Set 5:
Patch Set 5:
This based on if we know the return value 0 as success and otherwise failed. It's pretty common to use the below statement: if (rv != 0) return rv; But I checked the chromeec/ec.c. Looks like there are no consistent rule on this coding style. Some people check '!= 0' some didn't. What's you prefer?
I don't think there is a consistent rule about it. I have seen both usages within coreboot. I am not against this change, but I think the commit message would need some work. This change doesn't really "correct get board version". It is only a change for readability. So, the commit message should reflect that correctly.