Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37215 )
Change subject: pci_ids: Add Intel C620 PCIe IDs ......................................................................
Patch Set 1: Code-Review-1
(6 comments)
https://review.coreboot.org/c/coreboot/+/37215/1/src/include/device/pci_ids.... File src/include/device/pci_ids.h:
https://review.coreboot.org/c/coreboot/+/37215/1/src/include/device/pci_ids.... PS1, Line 2720: #define PCI_DEVICE_ID_INTEL_LWB_C621 0xa1c1 Please see https://review.coreboot.org/c/coreboot/+/35030
https://review.coreboot.org/c/coreboot/+/37215/1/src/include/device/pci_ids.... PS1, Line 2804: PCI_DEVICE_ID_INTEL_C620_LPC 0xA1C1 This ID already exist - PCI_DEVICE_ID_INTEL_LWB_C621
https://review.coreboot.org/c/coreboot/+/37215/1/src/include/device/pci_ids.... PS1, Line 3045: PCI_DEVICE_ID_INTEL_C620_PMC 0xa1a1 duplicates PCI_DEVICE_ID_INTEL_LWB_PMC
https://review.coreboot.org/c/coreboot/+/37215/1/src/include/device/pci_ids.... PS1, Line 3176: PCI_DEVICE_ID_INTEL_C620_SPI duplicates PCI_DEVICE_ID_INTEL_LWB_SPI
https://review.coreboot.org/c/coreboot/+/37215/1/src/include/device/pci_ids.... PS1, Line 3336: PCI_DEVICE_ID_INTEL_C620_SMBUS duplicates PCI_DEVICE_ID_INTEL_KBP_H_LWB_SMBUS
https://review.coreboot.org/c/coreboot/+/37215/1/src/include/device/pci_ids.... PS1, Line 3365: #define PCI_DEVICE_ID_INTEL_C620_P2SB 0xa1a0 duplicates PCI_DEVICE_ID_INTEL_LWB_P2SB