Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44708 )
Change subject: soc/mediatek/mt8192: Update initial settings of dramc
......................................................................
Patch Set 39:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44708/39/src/soc/mediatek/mt8192/dr...
File src/soc/mediatek/mt8192/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/44708/39/src/soc/mediatek/mt8192/dr...
PS39, Line 182: memcpy(result, &cali->impedance.result, sizeof(result));
should we make sure impedance.result has exactly same size as result? (if yes please add assert)
And can you clarify why not just make a pointer to cali->impedance.result?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44708
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08326cd1e6f7415d3a91d1591678e1b2c52c6781
Gerrit-Change-Number: 44708
Gerrit-PatchSet: 39
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 17 Dec 2020 03:29:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment