11 Sep
2019
11 Sep
'19
12:59 a.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35204 )
Change subject: mb/google/hatch: Distinguish SKU1 and 2 for eMMC and SSD respectively ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35204/7/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/gpio.c:
https://review.coreboot.org/c/coreboot/+/35204/7/src/mainboard/google/hatch/... PS7, Line 238: /* For SSD SKU */ What if SKU ID is 255? Don't you need to configure both SSD and eMMC GPIOs?
--
To view, visit https://review.coreboot.org/c/coreboot/+/35204
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I827e6f1420801d43e0eb4708b8b8ad1692ef7e9f
Gerrit-Change-Number: 35204
Gerrit-PatchSet: 7
Gerrit-Owner: Peichao Li peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Marco Chen marcochen@google.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Peichao Li peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Philip Chen philipchen@google.com
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-CC: Guohui Zhou guohui.zhou@bitland.corp-partner.google.com
Gerrit-Comment-Date: Wed, 11 Sep 2019 00:59:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment