Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39893 )
Change subject: Documentation: Add proposal for firmware unit testing ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39893/2/Documentation/technotes/202... File Documentation/technotes/2020-03-unit-testing-coreboot.md:
https://review.coreboot.org/c/coreboot/+/39893/2/Documentation/technotes/202... PS2, Line 85: tool toolchain You use the term toolchain below, so it makes sense to use it here.
https://review.coreboot.org/c/coreboot/+/39893/2/Documentation/technotes/202... PS2, Line 89: Compiler for the host : _must_ support the same language standards as the target compiler. This needs to be the first sentence in this section, as it is a requirement. Everything else is a nice-to-have or an explanation of why it's nice to have.
https://review.coreboot.org/c/coreboot/+/39893/2/Documentation/technotes/202... PS2, Line 106: * Same language for tests and code : : Unit tests will be written in C, because coreboot code is also written in C This might be a requirement, not a desirable. The only exception I see would be using GoogleTest (C++) to test C code. But using GoogleMock (also C++) to test C code is much harder.