EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41725 )
Change subject: soc/intel/tigerlake: Correct GPIO community PID configuration
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41725/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/41725/1//COMMIT_MSG@9
PS1, Line 9: retuns
returns
Done
https://review.coreboot.org/c/coreboot/+/41725/1//COMMIT_MSG@13
PS1, Line 13: TEST=Verify PCR port id is correct for each community.
Looking at what logs or using what tool?
Add printf log and check kernel log with aml_debug enable. Should I add this in the comment?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41725
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5dc48e5b31f43853b3a613c17f13f7df71f1fbfa
Gerrit-Change-Number: 41725
Gerrit-PatchSet: 2
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 26 May 2020 15:52:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment