Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38984 )
Change subject: mb/google/{auron,slippy}/ec: clear pending events on S3 wakeup
......................................................................
Patch Set 3:
Side-effect of this change would be that if you close lid in depthcharge or later phases of coreboot, it wouldn't result in shut down. In developer and normal mode, it would just boot to OS and shut down there. In case of recovery, I believe it would just be stuck at the recovery screen.
I see some common code that checks to see if the lid is closed. Is that not being used for this platform?
https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/pl...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38984
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ec9ec575d41c5b7522c4e13fc32b0b7c77d20d9
Gerrit-Change-Number: 38984
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Comment-Date: Mon, 24 Feb 2020 16:33:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment