Attention is currently required from: Angel Pons, Federico Amedeo Izzo, Felix Singer.
Felix Held has posted comments on this change by Federico Amedeo Izzo. ( https://review.coreboot.org/c/coreboot/+/82010?usp=email )
Change subject: mb/aoostar: Add Alder Lake based AOOSTAR R1 (WTR_R1) ......................................................................
Patch Set 14:
(1 comment)
File src/mainboard/aoostar/wtr_r1/gpio.h:
PS14: i wonder if the more high level gpio configuration macros could be used here instead of _PAD_CFG_STRUCT. https://review.coreboot.org/c/coreboot/+/81595/13/src/mainboard/cwwk/adl/gpi... for example matches what i've seen being used in most mainboards using Intel SoCs. if you change to using the more high level macros, you can use 'make BUILD_TIMELESS=1' in the build before and after changing the macros and compare the resulting files; if they are identical, you can be sure the new macros will evaluate to the same raw values to not have that cause any regression. if it's not possible to get the same raw values using the more high level macros, feel free to just ack this one to not block this patch and possibly look into that later