Prashant Malani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40424 )
Change subject: ec/google/chromeec: Add support for USB Type-C alternate mode control ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40424/1/src/ec/google/chromeec/acpi... File src/ec/google/chromeec/acpi/cros_ec.asl:
https://review.coreboot.org/c/coreboot/+/40424/1/src/ec/google/chromeec/acpi... PS1, Line 82: Package () { "data-role", "dual" }, port-number also needs to specified as a property (This is of course, handled by the SSDT generation code)
https://review.coreboot.org/c/coreboot/+/40424/1/src/ec/google/chromeec/acpi... PS1, Line 91: /* Thunderbolt 3 alternate mode */ : Device (TBT3) : { : Name (_ADR, 0) : : Name (_DSD, Package () { : ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), : Package() { : Package () { "svid", 0x8087 }, : Package () { "vdo", 1 }, : } : }) : : Method (_STA, 0, NotSerialized) : { : Return (0x0F) : } : } : : /* Display Port alternate mode */ : Device (DP) : { : Name (_ADR, 1) : Name (_DSD, Package () { : ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), : Package() { : Package () { "svid", 0xff01 }, : Package () { "vdo", 0x1c46 }, : } : }) : } We've still not decided how to define alternate mode support, so we should leave this out for upstream patches (for now)