Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41824 )
Change subject: commonlib: Add CBFS_TYPE_BOOTBLOCK
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41824/4//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/41824/4//COMMIT_MSG@9
PS4, Line 9: Add CBFS_TYPE_BOOTBLOCK to allow accessing the bootblock as a CBFS file.
Note that you don't *need* to specify the type to access a file, you can always just pass NULL for the type to cbfs_boot_locate() (in fact I think most of the code that does an explicit type lookup probably doesn't need to and shouldn't).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41824
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibb03ac3a6cd8711e0402e47335bb8e110c6ef61a
Gerrit-Change-Number: 41824
Gerrit-PatchSet: 4
Gerrit-Owner: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 28 May 2020 21:05:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment