30 Sep
2020
30 Sep
'20
11:15 p.m.
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45878 )
Change subject: tigerlake mainboards: switch to devtree aliases for PMC MUX connectors ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45878/2/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/volteer/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45878/2/src/mainboard/google/voltee... PS2, Line 245: conn1 How does it know which conn1 reference one to use? I am surprised this doesn't error out with the alias 'conn1' already existing, maybe because the find_alias() check in sconfig is only looking at base_root_dev?
--
To view, visit https://review.coreboot.org/c/coreboot/+/45878
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib51764da5b3c029f9ac7ac60199a0aedfc7f29b1
Gerrit-Change-Number: 45878
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 30 Sep 2020 21:15:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment