Attention is currently required from: Kyösti Mälkki, Patrick Rudolph. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59008 )
Change subject: mb/google,samsung: Refactor init_bootmode_straps() ......................................................................
Patch Set 2:
(1 comment)
File src/include/bootmode.h:
https://review.coreboot.org/c/coreboot/+/59008/comment/15581748_290e740a PS2, Line 19: void stash_bootmode(int flag_spi_wp, int flag_rec_mode); This is an old ugly hack on ancient devices that I'd prefer not to propagate to a top level API if possible. I don't even know why they needed to do that anyway (normally, on all the devices I've worked on, re-reading a GPIO in a later stage is not a big deal that requires caching). I don't think we'll ever need this again. If you think we need to deduplicate the code from the old boards, please hide it away in some Intel southbridge header.