Attention is currently required from: Michał Żygowski, Maxim Polyakov, Angel Pons. Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63403 )
Change subject: util/intelp2m: Add support for Alder Lake macro generation ......................................................................
Patch Set 4:
(5 comments)
File util/intelp2m/description.md:
https://review.coreboot.org/c/coreboot/+/63403/comment/9f93b594_82da217f PS1, Line 39: AlderLake-H
In order for intelp2m to work correctly for all variants of the Adler Lake family, it is necessary t […]
Added missing pad group names to the list in KeywordsCheck.
File util/intelp2m/description.md:
https://review.coreboot.org/c/coreboot/+/63403/comment/0ddb1e7e_957a5acd PS3, Line 39: AlderLake-H
Alder Lake?
Done
File util/intelp2m/gpio_adl_h.h:
PS3:
Unnecessary file
Done
File util/intelp2m/platforms/adl/macro.go:
https://review.coreboot.org/c/coreboot/+/63403/comment/0f56a9e3_9905c7e9 PS3, Line 99: macro := common.GetInstanceMacro(PlatformSpecific{InheritanceMacro : cnl.PlatformSpecific{}}, : fields.InterfaceGet())
macro := common.GetInstanceMacro( […]
Applied, still same issue though:
``` $ ./intelp2m -file ~/inteltool.log -iiii -fld cb -p adl -o gpio_adl_h.h 1 msi_pro_z690_a/intelp2m_adl!? Info level: Use level 4! Log file: /home/mkopec/inteltool.log Output generated file: gpio_adl_h.h Parse IntelTool Log File... panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x4c2bd8]
goroutine 1 [running]: _/home/mkopec/Development/Dasharo/coreboot/util/intelp2m/platforms/cnl.PlatformSpecific.KeywordCheck(...) /home/mkopec/Development/Dasharo/coreboot/util/intelp2m/platforms/cnl/template.go:23 _/home/mkopec/Development/Dasharo/coreboot/util/intelp2m/platforms/adl.PlatformSpecific.KeywordCheck(...) /home/mkopec/Development/Dasharo/coreboot/util/intelp2m/platforms/adl/template.go:24 _/home/mkopec/Development/Dasharo/coreboot/util/intelp2m/parser.(*ParserData).Parse(0xc000080f10) /home/mkopec/Development/Dasharo/coreboot/util/intelp2m/parser/parser.go:236 +0x7a3 main.main() /home/mkopec/Development/Dasharo/coreboot/util/intelp2m/main.go:137 +0x8c9 ```
File util/intelp2m/platforms/adlh/macro.go:
https://review.coreboot.org/c/coreboot/+/63403/comment/8284b630_e0a7a237 PS2, Line 20: MAX_DW_NUM = common.MAX_DW_NUM
Are DW2 and DW3 values contained in the GPIO registers dump from inteltool for this platforms? […]
They aren't. Here's a sample of inteltool output:
``` CPU: ID 0x90672, Processor Type 0x0, Family 0x6, Model 0x97, Stepping 0x2 Northbridge: 8086:4648 (12th generation (Alder Lake S family) Core Processor (Desktop)) Southbridge: 8086:7a84 (Z690) IGD: 8086:4680 (Intel(R) AlderLake-S GT1) SBREG_BAR = 0xe0000000 (MEM)
============= GPIOS =============
------- GPIO Community 0 -------
PCR Port ID: 0x6e0000
------- GPIO Group GPP_I ------- 0x0700: 0x0000001884000102 GPP_I0 GPIO 0x0710: 0x0000001984000500 GPP_I1 DDSP_HPD1 0x0720: 0x0000001a84000500 GPP_I2 DDSP_HPD2 0x0730: 0x0000001b84000502 GPP_I3 DDSP_HPD3 0x0740: 0x0000001c84000500 GPP_I4 DDSP_HPD4 0x0750: 0x0000001d84000500 GPP_I5 DDPB_CTRLCLK 0x0760: 0x0000001e84000500 GPP_I6 DDPB_CTRLDATA 0x0770: 0x0000002084000500 GPP_I7 DDPC_CTRLCLK 0x0780: 0x0000002184000500 GPP_I8 DDPC_CTRLDATA 0x0790: 0x0000002284000102 GPP_I9 GPIO 0x07a0: 0x0000002384000102 GPP_I10 GPIO 0x07b0: 0x0000002484000502 GPP_I11 USB_OC4# 0x07c0: 0x0000002584000502 GPP_I12 USB_OC5# 0x07d0: 0x0000002684000502 GPP_I13 USB_OC6# 0x07e0: 0x0000002784000502 GPP_I14 USB_OC7# 0x07f0: 0x0000002884000102 GPP_I15 GPIO 0x0800: 0x0000002984000102 GPP_I16 GPIO 0x0810: 0x0000002a84000102 GPP_I17 GPIO 0x0820: 0x0000002b84000102 GPP_I18 GPIO 0x0830: 0x0000002c84000102 GPP_I19 GPIO 0x0840: 0x0000002d84000102 GPP_I20 GPIO 0x0850: 0x0000002e84000102 GPP_I21 GPIO 0x0860: 0x0000003084000102 GPP_I22 GPIO 0x0870: 0x0000000040000700 GSPI0_CLK_LOOPBK GSPI0_CLK_LOOPBK 0x0880: 0x0000000040000700 GSPI1_CLK_LOOPBK GSPI1_CLK_LOOPBK ```