John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32903 )
Change subject: soc/intel/apollolake: Fix value stored to gnvs is never read
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/32903/7/src/soc/intel/apollolake/chip.c
File src/soc/intel/apollolake/chip.c:
https://review.coreboot.org/#/c/32903/7/src/soc/intel/apollolake/chip.c@419
PS7, Line 419: global_nvs_t
struct global_nvs_t
typedef struct global_nvs_t {
....
} __packed global_nvs_t;
It appears valid with global_nvs_t usage.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32903
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9421af4a556d1d88183aa938ee2a124a10ab727
Gerrit-Change-Number: 32903
Gerrit-PatchSet: 7
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Jacob Garber
jgarber1@ualberta.ca
Gerrit-CC: Lijian Zhao
lijian.zhao@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 23 May 2019 21:08:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment