Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34656 )
Change subject: soc/intel/common/basecode: Configure top swap based on ucode version
......................................................................
Patch Set 25: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/34656/25/src/soc/intel/common/basec...
File src/soc/intel/common/basecode/include/intelbasecode/ucode_update.h:
https://review.coreboot.org/c/coreboot/+/34656/25/src/soc/intel/common/basec...
PS25, Line 28: bootblock
maybe add "in the bootblock, preferably after console init"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34656
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ed2ca9e350acf0385ce5d790d319235df6c9f21
Gerrit-Change-Number: 34656
Gerrit-PatchSet: 25
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 25 Nov 2020 12:45:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment